This is the mail archive of the cluster-cvs@sourceware.org mailing list for the cluster.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

master - rgmanager: randomize SAPDatabase temp file even more


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=5265ab0f6ff4c8ce94fab7e7839c0b0e99aa94f8
Commit:        5265ab0f6ff4c8ce94fab7e7839c0b0e99aa94f8
Parent:        18077be27b80b59f36187f8291028ef8c6f983d4
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Oct 30 10:32:11 2008 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Thu Oct 30 10:32:11 2008 +0100

rgmanager: randomize SAPDatabase temp file even more

ad4d9bd9216d6fa259118017bac8b5c032b7b3b9 didn't introduce enough
security.

Switch to mktemp(1).

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 rgmanager/src/resources/SAPDatabase |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/resources/SAPDatabase b/rgmanager/src/resources/SAPDatabase
index 533b91b..49b5cbc 100644
--- a/rgmanager/src/resources/SAPDatabase
+++ b/rgmanager/src/resources/SAPDatabase
@@ -555,7 +555,7 @@ then
 fi
 
 # Set a tempfile and make sure to clean it up again
-TEMPFILE="/tmp/SAPDatabase.tmp.$$"
+TEMPFILE="$(mktemp -t /tmp/SAPDatabase.tmp.XXXXXX)"
 trap trap_handler INT TERM
 
 # These operations don't require OCF instance parameters to be set


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]