This is the mail archive of the cluster-cvs@sourceware.org mailing list for the cluster.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

master - fence_scsi.pl: check if nodeid is zero


Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=88fb54d63ea2575e950e77d48c522ac4bfd1aad1
Commit:        88fb54d63ea2575e950e77d48c522ac4bfd1aad1
Parent:        1b4bd5be033b91ed355e2ca47e3811c89a518010
Author:        rohara <rohara@spartan.(none)>
AuthorDate:    Thu Sep 4 16:25:56 2008 -0500
Committer:     Ryan O'Hara <rohara@redhat.com>
CommitterDate: Mon Sep 29 09:15:31 2008 -0500

fence_scsi.pl: check if nodeid is zero

If the nodeid we get from the XML query of cluster.conf is zero,
then either the node does not exist in the cluster of the nodeid
is not set. Each case is invalid, so report an error and exit.
---
 fence/agents/scsi/fence_scsi.pl |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fence/agents/scsi/fence_scsi.pl b/fence/agents/scsi/fence_scsi.pl
index d5a8d08..5a37135 100644
--- a/fence/agents/scsi/fence_scsi.pl
+++ b/fence/agents/scsi/fence_scsi.pl
@@ -199,6 +199,10 @@ sub get_key
     my $cluster_id = get_cluster_id;
     my $node_id = get_node_id($node);
 
+    if ($node_id == 0) {
+	die "Unable to determine nodeid for $node.\n";
+    }
+
     my $key = sprintf "%x%.4x", $cluster_id, $node_id;
 
     return $key;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]