This is the mail archive of the
cluster-cvs@sourceware.org
mailing list for the cluster.
RHEL5 - [FENCE] Fix #290231 - "Switch (optional)" param does notdefault to "1" and program fails
- From: Marek GrÃc <marx at fedoraproject dot org>
- To: cluster-cvs-relay at redhat dot com
- Date: Wed, 24 Sep 2008 14:58:39 +0000 (UTC)
- Subject: RHEL5 - [FENCE] Fix #290231 - "Switch (optional)" param does notdefault to "1" and program fails
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=447a6bab4e1a00f6cb60198923c7847c441949f3
Commit: 447a6bab4e1a00f6cb60198923c7847c441949f3
Parent: 20451b5c73ba42447aee9f0917839258ee1dfc62
Author: Marek 'marx' Grac <mgrac@redhat.com>
AuthorDate: Wed Sep 24 16:46:35 2008 +0200
Committer: Marek 'marx' Grac <mgrac@redhat.com>
CommitterDate: Wed Sep 24 16:46:35 2008 +0200
[FENCE] Fix #290231 - "Switch (optional)" param does not default to "1" and program fails
Bug itself was almost corrected in new fence agent but unfortunately '1' was
entered as number not as string. Python can not do int + string and agent fails.
---
fence/agents/apc/fence_apc.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fence/agents/apc/fence_apc.py b/fence/agents/apc/fence_apc.py
index e9d7f25..bf25050 100755
--- a/fence/agents/apc/fence_apc.py
+++ b/fence/agents/apc/fence_apc.py
@@ -42,7 +42,7 @@ def get_power_status(conn, options):
fail_usage("Failed: You have to enter physical switch number")
else:
if (0 == options.has_key("-s")):
- options["-s"] = 1
+ options["-s"] = "1"
if (None == re.compile('.*Outlet Management.*', re.IGNORECASE | re.S).match(conn.before)):
version = 2