[PATCH, V5 00/10] Definition and Implementation of CTF Frame format
Alan Modra
amodra@gmail.com
Thu Jul 28 01:59:27 GMT 2022
On Wed, Jul 20, 2022 at 06:19:23PM +0200, Jose E. Marchesi via Binutils wrote:
> Any chance we can have a review for this patch series?
I applied the patch series, regenerated libctfframe/configure, and ran
my normal set of regression tests. The libctfframe tests failed on
every target. On native x86_64-linux:
libctfframe/testsuite/libctfframe.decode/bigendian_data.c:91:24: warning: too many arguments for format
[-Wformat-extra-args]
91 | fprintf (stderr, "Decode: Fail to get funcdesc\n", ctf_frame_errmsg (err));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
On any cross-target I get ERROR: $target-cc does not exist, or
complaints like ./.libs/libctfframe.a(libctfframe_la-ctf-frame.o):
Relocations in generic ELF (EM: 62). That's due to trying to link
host objects into a target executable.
So, no, the patch series is not OK without that fixed. I did glance
over the patches and other than that they look OK, but I would expect
Nick Alcock to handle most of the review.
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list