This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] PR 22868: Fix case where IR file provides symbol visibility but replacement file does not
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Tue, 27 Mar 2018 18:45:43 -0700
- Subject: Re: [gold patch] PR 22868: Fix case where IR file provides symbol visibility but replacement file does not
- References: <CAJimCsHL_4NprnjOHKraACznMrOgoJpn2Tf1Z9Dc=yScYru9ig@mail.gmail.com>
Nick,
Is this OK for the 2.30 branch?
-cary
On Mon, Mar 26, 2018 at 11:17 AM, Cary Coutant <ccoutant@gmail.com> wrote:
> In PR 22868, two IR files provide conflicting visibility for a symbol.
> When a def with PROTECTED visibility is seen after a def with DEFAULT
> visibility, gold does not override the visibility. Later, if the
> replacement object define the symbol with DEFAULT visibility, the symbol
> remains DEFAULT. This was caused by a recent change to allow multiply-defined
> absolute symbols, combined with the fact that the plugin framework was using
> SHN_ABS as the section index for placeholder symbols. The solution is to
> use a real (but arbitrary) section index.
>
> -cary
>
> 2018-03-26 Cary Coutant <ccoutant@gmail.com>
>
> gold/
> PR gold/22868
> * plugin.cc (Sized_pluginobj::do_add_symbols): Use a real section
> index instead of SHN_ABS for defined symbols.
> * testsuite/Makefile.am (plugin_pr22868): New test case.
> * testsuite/Makefile.in: Regenerate
> * testsuite/plugin_pr22868.sh: New test script.
> * testsuite/plugin_pr22868_a.c: New source file.
> * testsuite/plugin_pr22868_b.c: New source file.