This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Feature request: improved build-id generation


>> Then I'm stating my case poorly.  I want a way to inject additional
>> data into the has computation.
>
> At one point, we proposed doing this via a linker- or assembler-oriented
> extra "salt" parameter, which would be hashed into the buildid.  This
> would most naturally be a n-v-r-a string, so the build is reproducible.
> Such a salt could be naturally injected via an environment variable set
> by rpmbuild.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1002341 (salt!)
> https://bugzilla.redhat.com/show_bug.cgi?id=1550152 (life without salt)

I don't have a problem with adding a --build-id-salt="some arbitrary
string" option, and I think "salt" is exactly the right term for this.
I'd much prefer providing that than having you use a linker script.
(I'm somewhat puzzled that you find the linker script option less
objectionable than an object file with a note section.)

As Nick said earlier, it's not that we don't care about your feature
request. I simply wanted to explore the options, and I gave you a
couple of options that require no new features at all.

My other comments have been about the unnecessary conflating of a new
option like --build-id-salt with the choice of hashing algorithm.

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]