This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: Add .nop directive to assembler
On Fri, 16 Feb 2018, Alan Modra wrote:
> > Good points. Here is the updated patch. OK for master?
>
> OK, except for one quibble with the default md_generate_nops. I think
> that should error rather than filling with zeros (which is likely to
> be an illegal instruction or trap).
I have a feeling the default should wire in HANDLE_ALIGN somehow. For
many targets, such as fixed instruction width RISC processors, there is
only going to be one way of filling a given amount of space with no-op
instructions, so I think there's no point in having code duplication
here. And even if there are more ways possible for a given target, then
the `.align' way is still right even if suboptimal.
Maciej