This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][BINUTILs][GAS][AArch64] Add support for V_4B so we can properly reject it. [Patch (1/2)]
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Marcus Shawcroft" <Marcus dot Shawcroft at arm dot com>
- Date: Mon, 18 Dec 2017 11:47:41 +0000
- Subject: Re: [PATCH][BINUTILs][GAS][AArch64] Add support for V_4B so we can properly reject it. [Patch (1/2)]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- Nodisclaimer: True
- References: <20171207154912.GA9411@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Ping
________________________________________
From: binutils-owner@sourceware.org <binutils-owner@sourceware.org> on behalf of Tamar Christina <tamar.christina@arm.com>
Sent: Thursday, December 7, 2017 3:49:28 PM
To: binutils@sourceware.org
Cc: nd; Richard Earnshaw; Marcus Shawcroft
Subject: [PATCH][BINUTILs][GAS][AArch64] Add support for V_4B so we can properly reject it. [Patch (1/2)]
Hi All,
Previously parse_vector_type_for_operand was changed to allow the use of 4b
register size for indexed lane instructions. However this had the unintended
side effect of also allowing 4b for normal vector registers.
Because this support was only partial the rest of the tool silently treated
4b as 8b and continued. This patch adds full support for 4b so it can be
properly distinguished from 8b and the correct errors are generated.
With this patch you still can't encode any instruction which actually requires
v<num>.4b but such instructions don't exist so to prevent needing a workaround
in get_vreg_qualifier_from_value this was just omitted.
Regtested on:
* aarch64-none-elf (cross)
* aarch64_be-none-elf (cross)
* aarch64-none-elf (native)
* aarch64-none-elf (native on 32bit host)
and no issues.
Ok for master?
Thanks,
Tamar.
gas/
2017-12-07 Tamar Christina <tamar.christina@arm.com>
PR gas/22529
* config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_QLF_V_4B.
* gas/testsuite/gas/aarch64/pr22529.s: New.
* gas/testsuite/gas/aarch64/pr22529.d: New.
* gas/testsuite/gas/aarch64/pr22529.l: New.
include/
2017-12-07 Tamar Christina <tamar.christina@arm.com>
PR gas/22529
* opcode/aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_V_4B.
opcodes/
2017-12-07 Tamar Christina <tamar.christina@arm.com>
PR gas/22529
* aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant.
--