Re: [PATCH] ld: Set non_ir_ref_regular on symbols referenced in regular objects

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

Thanks for the quick fix. I've checked it locally and it works fine for me.

Best regards,

Thomas

On 27/11/17 23:45, H.J. Lu wrote:
> On Mon, Nov 27, 2017 at 2:57 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Mon, Nov 27, 2017 at 11:29 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> > > If check_relocs is called after opening all inputs and the new defitinion
> > > from an IR object overrides the old weak defitinion in a regular object,
> > > set non_ir_ref_regular so that linker plugin will get the correct symbol
> > > resolution.
> > >
> > > OK for master?
> > >
> > >
> > > H.J.
> > > ---
> > > bfd/
> > >
> > >          PR ld/22502
> > >          * elflink.c (_bfd_elf_merge_symbol): Also skip definition from
> > >          an IR object.
> > >          * linker.c (_bfd_generic_link_add_one_symbol): If check_relocs
> > >          is called after opening all inputs, set non_ir_ref_regular.
> >
> > Here is a better patch.
>
> The updated path to check for badly formatted input files.