This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: string insns don't allow displacements
>>> On 10.11.17 at 13:56, <hjl.tools@gmail.com> wrote:
> On Fri, Nov 10, 2017 at 4:31 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> x86: string insns don't allow displacements
>>
>> Remove the misleading indicators from the table.
>>
>> gas/
>> 2017-11-10 Jan Beulich <jbeulich@suse.com>
>>
>> * testsuite/gas/i386/string-ok.s: Add a few more valid patterns.
>> Move bogus tests ...
>> * testsuite/gas/i386/string-bad.s: ... here.
>> * testsuite/gas/i386/string-bad.l: Adjust expectations.
>> * testsuite/gas/i386/string-ok.d: Likewise.
>> * testsuite/gas/i386/string-ok.e: Likewise.
>>
>>
>> opcodes/
>> 2017-11-10 Jan Beulich <jbeulich@suse.com>
>>
>> * i386-opc.tbl (cmps, ins, lods, movs, outs, scas, scmp, slod,
>> smov, ssca, stos, ssto, xlat): Drop Disp*.
>> * i386-tbl.h: Re-generate.
>>
>> --- 2017-11-10/gas/testsuite/gas/i386/string-bad.l
>> +++ 2017-11-10/gas/testsuite/gas/i386/string-bad.l
>> @@ -6,12 +6,24 @@
>> .*:8: Error: .*
>> .*:9: Error: .*
>> .*:10: Error: .*
>> -.*:14: Error: .*
>> +.*:11: Warning: .*
>> +.*:12: Warning: .*
>> +.*:13: Warning: .*
>> +.*:14: Warning: .*
>> +.*:15: Warning: .*
>> .*:15: Error: .*
>> -.*:16: Error: .*
>> -.*:17: Error: .*
>> -.*:18: Error: .*
>> .*:19: Error: .*
>> .*:20: Error: .*
>> .*:21: Error: .*
>> .*:22: Error: .*
>> +.*:23: Error: .*
>> +.*:24: Error: .*
>> +.*:25: Error: .*
>> +.*:26: Error: .*
>> +.*:27: Error: .*
>> +.*:28: Warning: .*
>> +.*:29: Warning: .*
>> +.*:30: Warning: .*
>> +.*:31: Warning: .*
>> +.*:32: Warning: .*
>> +.*:32: Error: .*
>> --- 2017-11-10/gas/testsuite/gas/i386/string-bad.s
>> +++ 2017-11-10/gas/testsuite/gas/i386/string-bad.s
>> @@ -8,6 +8,11 @@ start:
>> cmpsb %ds:(%edi), (%esi)
>> scasb %ds:(%edi)
>> insb (%dx), %ds:(%edi)
>> + xlatb (%esi)
>> + xlatb (,%ebx)
>> + xlatb 1(%ebx)
>> + xlatb x(%ebx)
>> + xlatb 0
.../gas/testsuite/gas/i386/string-bad.s:11: Warning: `(%esi)' is not valid here (expected `(%ebx)')
.../gas/testsuite/gas/i386/string-bad.s:12: Warning: `(,%ebx)' is not valid here (expected `(%ebx)')
.../gas/testsuite/gas/i386/string-bad.s:13: Warning: `1(%ebx)' is not valid here (expected `(%ebx)')
.../gas/testsuite/gas/i386/string-bad.s:14: Warning: `x(%ebx)' is not valid here (expected `(%ebx)')
.../gas/testsuite/gas/i386/string-bad.s:15: Warning: `0' is not valid here (expected `(%ebx)')
.../gas/testsuite/gas/i386/string-bad.s:15: Error: operand type mismatch for `xlat'
Jan