This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH][GAS][ARM] Add Dot Product Extension as mandatory feature on Armv8.4-A [Patch (2/3)]


Hi Nick,

> >
> > 	* config/tc-arm.c (arm_extensions):
> > 	Add FPU_ARCH_DOTPROD_NEON_VFP_ARMV8.
> >         * testsuite/gas/arm/dotprod-mandatory.d: New test.
> 
> Applied.  Note - I dropped this frag from the patch:
> 
>   +static const arm_feature_set arm_ext_v8_4 =
>   +  ARM_FEATURE_CORE_HIGH (ARM_EXT2_V8_4A);

Thanks, I was trying to recreate the problem before I responded.
The value isn't really needed for ARM.

But I did find why I didn't catch it, my test
Scripts were essentially still cross compiling. So the error didn't show up.

I'll fix them so this'll be caught next time.

Thanks,
Tamar

> 
> If it really is needed then please submit a follow up patch.
> 
> Cheers
>   Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]