This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 0/3] Fix issues with writing Linux core PRSTATUS note on MIPS o32, n32 and n64 into core file
- From: Djordje Todorovic <djordje dot todorovic at rt-rk dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org, "nemanja dot popov at rt-rk dot com" <nemanja dot popov at rt-rk dot com>, petar dot jovanovic at rt-rk dot com, "Ananthakrishna Sowda (asowda)" <asowda at cisco dot com>, Nikola Prica <nikola dot prica at rt-rk dot com>, Pedro Alves <palves at redhat dot com>
- Date: Wed, 25 Oct 2017 16:14:54 +0200
- Subject: Re: [PATCH 0/3] Fix issues with writing Linux core PRSTATUS note on MIPS o32, n32 and n64 into core file
- Authentication-results: sourceware.org; auth=none
- References: <74618d56-fa31-4cfe-329f-6a9078bac92b@rt-rk.com> <alpine.DEB.2.00.1710171449200.3886@tp.orcam.me.uk>
Hi Maciej,
Please notice that I have reformatted patches 1/3 and 3/3, according your comments, and also tweaked a little bit patch 3/3.
Regarding patch 3/3, as Pedro said, currently “thread” function has a piece of code that is never going to be executed since core file is going to be generated as soon as the first thread reaches the thread function. So, since we are testing fetching value of TLS variable from core file, creating just a one thread in test case would be enough and regarding that, I have cut unnecessary code from the function.
Thanks,
Djordje