This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: christophe dot lyon at linaro dot org
- Cc: Nick Clifton <nickc at redhat dot com>, binutils at sourceware dot org, patches at groups dot riscv dot org, Andrew Waterman <andrew at sifive dot com>
- Date: Tue, 24 Oct 2017 10:33:32 -0700 (PDT)
- Subject: Re: [PATCH v2] RISC-V: Only relax to C.LUI when imm != 0 and rd != 0/2
- Authentication-results: sourceware.org; auth=none
On Tue, 24 Oct 2017 10:24:01 PDT (-0700), christophe.lyon@linaro.org wrote:
> On 24 October 2017 at 03:22, Palmer Dabbelt <palmer@dabbelt.com> wrote:
>> +if [is_target "riscv-*-*"] {
>> + run_dump_test "c-lui"
>> +}
>
> Hi,
>
> Since you committed this patch, I've noticed:
> ERROR: ld:(DejaGnu) proc "is_target riscv-*-*" does not exist.
>
> on all the targets I test (x86_64, aarch64, arm)
>
> Can you fix it?
Sorry about that. I think this should fix it? I don't have a build for any of
those targets floating around, but I'm generating one for x86_64 now...
commit c03bc61e9f74fc9ae4e76bf483211a987b078509
Author: Palmer Dabbelt <palmer@dabbelt.com>
Date: Tue Oct 24 10:26:27 2017 -0700
Fix ld-riscv-elf.exp for all targets
I used the wrong syntax when writing this the first time. I've copied
this from the MIPS version of this code, so hopefully it's correct this
time.
ld/ChangeLog
2017-10-24 Palmer Dabbelt <palmer@dabbelt.com>
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Use the correct
syntax to test for RISC-V targets.
diff --git a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
index efe012efec7d..ecc035f842d2 100644
--- a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
+++ b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
@@ -19,6 +19,8 @@
# MA 02110-1301, USA.
#
-if [is_target "riscv-*-*"] {
- run_dump_test "c-lui"
+if {![istarget riscv*-*-*] || ![is_elf_format]} {
+ return
}
+
+run_dump_test "c-lui"