This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] [GOLD] Add plugin API for processing plugin-added input files


On Wed, Oct 11, 2017 at 12:09 AM, Sriraman Tallam <tmsriram@google.com> wrote:
> On Mon, Sep 25, 2017 at 6:46 PM, Stephen Crane <sjc@immunant.com> wrote:
>> +# Copyright (C) 2011-2017 Free Software Foundation, Inc.
>> +# Written by Sriraman Tallam <tmsriram@google.com>.
>
> Copy paste error.

It seemed wrong to put my own name there, since I just slightly
modified what you wrote. Would the following be appropriate, or should
I just take your name off entirely?

# Copyright (C) 2017 Free Software Foundation, Inc.
# Originally written by Sriraman Tallam <tmsriram@google.com>, altered by
# Stephen Crane <sjc@immunant.com>.

Honestly, the more I think about it, I think it might just be best to
use a single shell script for both tests and not duplicate code. The
tests are distinct and use different plugins, but the validation is
identical. However, using the same script could make it unclear which
test failed when there is a failure. I'm not sure which is more
important here.

>> +# The goal of this program is to verify if plugin section reordering and
>> +# assignment works for plugin-created object files.  File final_layout.cc is in
>> +# this test.
>
> again copy paste error.

Indeed, should be plugin_final_layout.cc. I'll change that.


> It looks fine to me  but I cannot approve.
> Thanks
> Sri

Thanks for looking through this.

- stephen


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]