This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 0/4] Fix issues with handling of Linux core notes on MIPS o32, n32 and n64
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Djordje Todorovic <djordje dot todorovic at rt-rk dot com>
- Cc: <binutils at sourceware dot org>, <gdb-patches at sourceware dot org>, "nemanja dot popov at rt-rk dot com" <nemanja dot popov at rt-rk dot com>, <petar dot jovanovic at rt-rk dot com>, "Ananthakrishna Sowda (asowda)" <asowda at cisco dot com>, Nikola Prica <nikola dot prica at rt-rk dot com>
- Date: Thu, 12 Oct 2017 23:30:31 +0100
- Subject: Re: [PATCH 0/4] Fix issues with handling of Linux core notes on MIPS o32, n32 and n64
- Authentication-results: sourceware.org; auth=none
- References: <c5d22051-ecd5-7f9e-ce33-118482f92973@rt-rk.com>
Hi Djordje,
> Thank you for your comments and I really appreciate it! I have refactored the
> patches and addressed all of your proposals.
Thank you for the updated patches.
I tried to do some verification myself and tripped over a small technical
issue with them in that they have got garbled in transit; apparently all
leading spaces have become doubled, which prevents the affected changes
from being applied.
If your mail client makes it difficult to send text verbatim, then can
you please try a different solution, such as using `git send-email'?
This would also make handling easier as the tool groups the submission
into a thread.
Also please make the intended commit description the body of the
submission message; any further discussion, comments, questions, etc. then
go below a `---' marker. This is so that `git am' can be used to import
patches.
> This patch series addresses problems with writing Linux core PRSTATUS note
> into MIPS o32, n32 and n64 core files.
> Also, there is one patch which adds reading PID information from MIPS o32, n32
> and n64 core file.
Great, thanks for addressing this part as well!
> I have tested it on MIPS64R2 board with ʽmips-mti-linux-gnuʼ target and it is
> also tested with ʽx86_64-linux-gnuʼ target and these changes have passed
> binutils regression tests.
Thanks. Which ABI(s) specifically did you test for?
Maciej