This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Add elf64.lo together with elfxx-x86.lo for 64-bit BFD
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 30 Aug 2017 19:33:35 -0700
- Subject: PATCH: Add elf64.lo together with elfxx-x86.lo for 64-bit BFD
- Authentication-results: sourceware.org; auth=none
On Wed, Aug 30, 2017 at 6:04 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Aug 31, 2017 at 08:49:21AM +0930, Alan Modra wrote:
>> I'm testing the following fix.
>>
>> * opncls.c (bfd_close_all_done): Don't call bfd_cache_close
>> before _close_and_cleanup. Call iovec->bclose after.
>> (bfd_close): Remove code common to, and call bfd_close_all_done.
>
> Now committed. The test run showed breakage of all x86 non-ELF
> targets.
>
> ../bfd/.libs/libbfd.a(elfxx-x86.o): In function `_bfd_x86_elf_link_hash_table_create':
> /home/alan/src/binutils-gdb/bfd/elfxx-x86.c:269: undefined reference to `elf64_r_info'
> /home/alan/src/binutils-gdb/bfd/elfxx-x86.c:270: undefined reference to `elf64_r_sym'
>
I am going to check in this.
--
H.J.
From a28a6564f50da29ef1400b0c6eb32aa6c8d16915 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 30 Aug 2017 19:30:53 -0700
Subject: [PATCH] Add elf64.lo together with elfxx-x86.lo for 64-bit BFD
Since elfxx-x86.lo needs elf64.lo with 64-bit BFD, add elf64.lo together
with elfxx-x86.lo to bfd_backends for 64-bit BFD.
* configure.ac (bfd_backends): Add elf64.lo together with
elfxx-x86.lo for 64-bit BFD.
* configure: Regenerated.
---
bfd/ChangeLog | 6 ++++++
bfd/configure | 7 +++++++
bfd/configure.ac | 7 +++++++
3 files changed, 20 insertions(+)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 52a88f8d42..475b49af9d 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-08-30 H.J. Lu <hongjiu.lu@intel.com>
+
+ * configure.ac (bfd_backends): Add elf64.lo together with
+ elfxx-x86.lo for 64-bit BFD.
+ * configure: Regenerated.
+
2017-08-31 Alan Modra <amodra@gmail.com>
PR binutils/22032
diff --git a/bfd/configure b/bfd/configure
index 32ee062e80..dce88a1120 100755
--- a/bfd/configure
+++ b/bfd/configure
@@ -14758,6 +14758,13 @@ rm -f conftest*
;;
esac
+# elfxx-x86.lo needs elf64.lo with 64-bit BFD.
+case "${bfd_backends}-${wordsize}" in
+ *elfxx-x86.lo*-64*)
+ bfd_backends="${bfd_backends} elf64.lo"
+ ;;
+esac
+
tdefaults=""
test -n "${defvec}" && tdefaults="${tdefaults} -DDEFAULT_VECTOR=${defvec}"
test -n "${selvecs}" && tdefaults="${tdefaults} -DSELECT_VECS='${selvecs}'"
diff --git a/bfd/configure.ac b/bfd/configure.ac
index 0e4c669b7d..3f2cedfd63 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -825,6 +825,13 @@ case ${host64}-${target64}-${want64} in
;;
esac
+# elfxx-x86.lo needs elf64.lo with 64-bit BFD.
+case "${bfd_backends}-${wordsize}" in
+ *elfxx-x86.lo*-64*)
+ bfd_backends="${bfd_backends} elf64.lo"
+ ;;
+esac
+
tdefaults=""
test -n "${defvec}" && tdefaults="${tdefaults} -DDEFAULT_VECTOR=${defvec}"
test -n "${selvecs}" && tdefaults="${tdefaults} -DSELECT_VECS='${selvecs}'"
--
2.13.5