This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Also disallow global alias of common symbol
- From: Nick Clifton <nickc at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
- Date: Fri, 11 Aug 2017 12:16:31 +0100
- Subject: Re: [PATCH] Also disallow global alias of common symbol
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=nickc at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8311255883
- References: <20170810165921.GA6316@gmail.com>
Hi H.J.
> gas/
>
> PR gas/21667
> * read.c (pseudo_set): Update error message for alias of common
> symbol.
> * write.c (write_object_file): Disallow both local and global
> aliases of common symbol.
> * testsuite/gas/elf/common5a.d: New file.
> * testsuite/gas/elf/common5a.l: Likewise.
> * testsuite/gas/elf/common5a.s: Likewise.
> * testsuite/gas/elf/common5b.d: Likewise.
> * testsuite/gas/elf/common5b.l: Likewise.
> * testsuite/gas/elf/common5b.s: Likewise.
> * testsuite/gas/elf/common5c.d: Likewise.
> * testsuite/gas/elf/common5c.s: Likewise.
> * testsuite/gas/elf/common5d.d: Likewise.
> * testsuite/gas/elf/common5d.s: Likewise.
> * testsuite/gas/elf/elf.exp: Run common5a, common5b, common5c
> and common5d.
Approved - please apply.
Cheers
Nick