This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [AArch64][6/6] Core file support for "pauth" feature
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Jiong Wang <jiong dot wang at foss dot arm dot com>, GDB <gdb-patches at sourceware dot org>, Binutils <binutils at sourceware dot org>
- Date: Thu, 10 Aug 2017 21:22:38 +0000
- Subject: Re: [AArch64][6/6] Core file support for "pauth" feature
- Authentication-results: sourceware.org; auth=none
- References: <e4493fb7-9792-1bda-0011-808ac36418ae@foss.arm.com> <fa73a1a8-aafa-d332-9781-ac61893e7a53@redhat.com>
On 17-08-10 12:08:36, Pedro Alves wrote:
> > +#ifndef HWCAP_APIA
> > +/* AArch64 GNU/Linux HWCAP values. These should be synced with kernel
> > + definitions. */
> > +#define HWCAP_APIA (1 << 16)
> > +#endif
>
> Re. the #ifndef, consider that tdep.h files are included in cross
> debugger builds. E.g., an x86-hosted gdb cross debugging aarch64.
> Some archs have "namespaced" names like the s390 mips, sparc, etc.
> (e.g., HWCAP_S390_VX) which avoids the case of the names being defined
> on host/target with a different meanings/values, but not all do.
> But even with such names, we always have to provide fallback definitions
> for cross debuggers. And with that all in mind, and since you're defining
> fallbacks anyway, how about unconditionally defining/using our
> own conflict-resistant versions, like AARCH64_HWCAP_APIA?
>
I am inclined to use the same macro name as kernel uses. These macros are
only used in $arch-linux-{tdep,nat}.c, so it is clear that the macros
are about architecture $arch.
--
Yao (齐尧)