This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add configure flag to enable gnu hash style by default.

From: Alan Modra <amodra at gmail dot com>
To: Romain Geissler <romain dot geissler at gmail dot com>
Cc: binutils at sourceware dot org
Date: Wed, 19 Jul 2017 14:59:57 +0930
Subject: Re: [PATCH] Add configure flag to enable gnu hash style by default.
Authentication-results: sourceware.org; auth=none
References: <20170712215007.22877-1-romain.geissler@gmail.com> <20170718171936.3555-1-romain.geissler@gmail.com>

On Tue, Jul 18, 2017 at 05:19:36PM +0000, Romain Geissler wrote:
> Hi,
> 
> This is the second version of my hash style changes.
> 
> Changes since v1:
>  - use --enable-default-hash-style rather than --with-default-hash-style
>  - the default value is now "both" rather than "gnu"

Changing to "gnu" or "both" by default will be bad for non-GNU
systems.  I think you need to make the default conditional on target.

Also, this change needs testing on more than just x86_64-linux.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH] Add configure flag to enable gnu hash style by default.
  - From: Romain Geissler

References:
- [PATCH] Add configure flag to enable gnu hash style by default.
  - From: Romain Geissler
- [PATCH] Add configure flag to enable gnu hash style by default.
  - From: Romain Geissler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]