This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: testsuite results, binutils-2.29 branch
On Fri, Jul 07, 2017 at 11:55:37AM +0200, Matthias Klose wrote:
> On 07.07.2017 09:19, Alan Modra wrote:
> > On Thu, Jul 06, 2017 at 02:50:55PM +0200, Matthias Klose wrote:
> >> ppc64el:
> >> Running /<<PKGBUILDDIR>>/ld/testsuite/ld-ifunc/ifunc.exp ...
> >> FAIL: Could not link a dynamic executable using local ifunc
> >
> > ld.log shows ld emitting an error: "text relocations and GNU indirect
> > functions will result in a segfault at runtime".
> > This is the --enable-default-pie compiler problem fixed by
> > https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01678.html
>
> hmm, my impression was that you retracted that patch ...
I hope that's not what potential reviewers think!
> PR 80044 is closed as won't fix.
Yes, that's because I don't intend to make -pie -static work together
(with the traditional meaning of -static).
> However PR 81170 is still open.
and your PR 81295.
> >> Running /<<PKGBUILDDIR>>/ld/testsuite/ld-powerpc/powerpc.exp ...
> >> FAIL: ld-powerpc/ppc476-shared
> >> FAIL: ld-powerpc/ppc476-shared2
> >
> > I can't reproduce the above. Can I see your ld.log?
>
> attached.
The fails are due to Ubuntu patches, and a testcase that is too fussy
over expected output. Problem is that .dynamic and other sections sit
between .text and .bss, so anything like changing hash style makes
.bss move. This patch should make the tests more robust.
* testsuite/ld-powerpc/ppc476-shared.lnk: Align .bss.
* testsuite/ld-powerpc/ppc476-shared.d: Adjust.
* testsuite/ld-powerpc/ppc476-shared2.d: Adjust.
diff --git a/ld/testsuite/ld-powerpc/ppc476-shared.d b/ld/testsuite/ld-powerpc/ppc476-shared.d
index fe438f4..72f8a3d 100644
--- a/ld/testsuite/ld-powerpc/ppc476-shared.d
+++ b/ld/testsuite/ld-powerpc/ppc476-shared.d
@@ -23,7 +23,7 @@ Disassembly of section \.text:
\.\.\.
3fff0: (42 9f 00 05|05 00 9f 42) bcl .*
3fff4: (7d 28 02 a6|a6 02 28 7d) mflr r9
- 3fff8: (3d 29 00 00|00 00 29 3d) addis r9,r9,0
+ 3fff8: (3d 29 00 01|01 00 29 3d) addis r9,r9,1
3fff[8a]: R_PPC_REL16_HA \.bss\+0x[46]
3fffc: (48 00 00 34|34 00 00 48) b 40030 .*
40000: (3c 60 00 00|00 00 60 3c) lis r3,0
@@ -41,7 +41,7 @@ Disassembly of section \.text:
40024: (4b fe ff dc|dc ff fe 4b) b 30000 .*
40028: (48 00 00 02|02 00 00 48) ba 0 .*
4002c: (48 00 00 02|02 00 00 48) ba 0 .*
- 40030: (39 29 01 50|50 01 29 39) addi r9,r9,336
+ 40030: (39 29 00 0c|0c 00 29 39) addi r9,r9,12
4003[02]: R_PPC_REL16_LO \.bss\+0x3[ce]
40034: (4b ff ff cc|cc ff ff 4b) b 40000 .*
40038: (48 00 00 02|02 00 00 48) ba 0 .*
diff --git a/ld/testsuite/ld-powerpc/ppc476-shared.lnk b/ld/testsuite/ld-powerpc/ppc476-shared.lnk
index 5339358..03e66b3 100644
--- a/ld/testsuite/ld-powerpc/ppc476-shared.lnk
+++ b/ld/testsuite/ld-powerpc/ppc476-shared.lnk
@@ -2,5 +2,5 @@ SECTIONS
{
. = 0xfffc;
.text : { *(.text) }
- .bss : { *(.bss) }
+ .bss : ALIGN (0x10000) { *(.bss) }
}
diff --git a/ld/testsuite/ld-powerpc/ppc476-shared2.d b/ld/testsuite/ld-powerpc/ppc476-shared2.d
index 813ea2e..5bf0a03 100644
--- a/ld/testsuite/ld-powerpc/ppc476-shared2.d
+++ b/ld/testsuite/ld-powerpc/ppc476-shared2.d
@@ -8,9 +8,9 @@
DYNAMIC RELOCATION RECORDS
OFFSET TYPE VALUE
-0001000[02] R_PPC_ADDR16_LO \.text\+0x00040144
-0002000[02] R_PPC_ADDR16_LO \.text\+0x00040144
-0003000[02] R_PPC_ADDR16_LO \.text\+0x00040144
-0004000[02] R_PPC_ADDR16_HA \.text\+0x00040144
-0004001[02] R_PPC_ADDR16_HA \.text\+0x00040144
-0004002[02] R_PPC_ADDR16_HA \.text\+0x00040144
+0001000[02] R_PPC_ADDR16_LO \.text\+0x00050000
+0002000[02] R_PPC_ADDR16_LO \.text\+0x00050000
+0003000[02] R_PPC_ADDR16_LO \.text\+0x00050000
+0004000[02] R_PPC_ADDR16_HA \.text\+0x00050000
+0004001[02] R_PPC_ADDR16_HA \.text\+0x00050000
+0004002[02] R_PPC_ADDR16_HA \.text\+0x00050000
--
Alan Modra
Australia Development Lab, IBM