This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed 2/3] MIPS/LD/testsuite: mips-elf-flags: Use `remote_exec' to call `readelf'
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Tue, 27 Jun 2017 03:03:05 +0100
- Subject: [committed 2/3] MIPS/LD/testsuite: mips-elf-flags: Use `remote_exec' to call `readelf'
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.00.1706261936150.31404@tp.orcam.me.uk>
For ELF file header flag verification done in `good_combination' in the
`mips-elf-flags.exp' test script the version of `readelf' built along
with the rest of binutils has to be used rather than any such executable
already present on the build system, so that flags recognized by the
tool match those supported by LD being tested. Use `remote_exec' as
elsewhere in the LD test framework and also with GAS and LD used here,
getting and arranging for extra reporting of `readelf' calls included in
test logs on this occasion as well.
ld/
* testsuite/ld-mips-elf/mips-elf-flags.exp (good_combination):
Use `remote_exec' to call `readelf'. Log the command issued.
---
binutils-mips-ld-test-mips-elf-flags-readelf-remote.diff
Index: binutils/ld/testsuite/ld-mips-elf/mips-elf-flags.exp
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/mips-elf-flags.exp 2017-06-23 17:15:01.154304786 +0100
+++ binutils/ld/testsuite/ld-mips-elf/mips-elf-flags.exp 2017-06-23 22:27:23.334061400 +0100
@@ -70,8 +70,13 @@ proc good_combination {arglist flags} {
} elseif {![ld_link "$ld $ldemul" $finalobj "-r $objs"]} {
fail $testname
} else {
- catch "exec $READELF -h $finalobj" output
- if {![regexp "Flags: *(\[^\n\]*)" $output full gotflags]} {
+ set cmd "$READELF -h $finalobj"
+ send_log "$cmd\n"
+ set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]]]
+ set output [lindex $cmdret 1]
+ set cmdret [lindex $cmdret 0]
+ if {$cmdret != 0 \
+ || ![regexp "Flags: *(\[^\n\r\]*)" $output full gotflags]} {
unresolved $testname
} else {
set failed 0