This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, GAS/ARM] Fix expansion of ldr pseudo instruction
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Alan Modra <amodra at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, gingold at adacore dot com
- Date: Wed, 14 Jun 2017 10:25:20 +0100
- Subject: Re: [PATCH, GAS/ARM] Fix expansion of ldr pseudo instruction
- Authentication-results: sourceware.org; auth=none
- References: <0a39721c-906b-677d-b156-81daa05fac09@foss.arm.com> <d8c6bc4f-b515-cf63-30a7-99bcf7ff8553@redhat.com> <b2965d2f-4843-ac63-d265-86e9f366747a@foss.arm.com> <CAJA7tRYe5m+Qvq3+AciHVizFZLDCP1qF=Vm7YWjnrYEshDVHaA@mail.gmail.com>
On 14/06/17 10:11, Ramana Radhakrishnan wrote:
On Wed, Jun 14, 2017 at 9:49 AM, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
Patch applies cleanly on binutils-2_28-branch and shows no testsuite
regression. Is this ok to commit to binutils 2.28?
can you mark this as fixing PR21590 in your changelog for 2.28 ?
Sure, please ignore the ChangeLog in the patch, this is coming from the
cherry-pick. The proposed ChangeLog would be:
2017-06-14 Thomas Preud'homme <thomas.preudhomme@arm.com>
Backport from mainline
2017-04-24 Thomas Preud'homme <thomas.preudhomme@arm.com>
PR 21590
* config/tc-arm.c (move_or_literal_pool): Remove code generating MOVS.
Forbid MOV.W and MOVW if destination is SP or PC.
* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.s: Explain
expectation of LDR not generating a MOVS for low registers and small
constants. Add tests of MOVW generation.
* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Update
expected disassembly.
However you need an ACK from Tristan about 2.28.
Yes indeed, my mistake.
Also could you please note the sha1 which fixed this on trunk on the
bz for posterity ?
Done.
Best regards,
Thomas
regards
Ramana
Best regards,
Thomas
On 24/04/17 14:07, Nick Clifton wrote:
Hi Thomas,
2017-04-20 Thomas Preud'homme <thomas.preudhomme@arm.com>
* config/tc-arm.c (move_or_literal_pool): Remove code generating
MOVS.
Forbid MOV.W and MOVW if destination is SP or PC.
* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.s: Explain
expectation of LDR not generating a MOVS for low registers and small
constants. Add tests of MOVW generation.
* testsuite/gas/arm/thumb2_ldr_immediate_highregs_armv6t2.d: Update
expected disassembly.
Approved - please apply.
Cheers
Nick