This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/9] [ARC] Avoid creating dynamic relocs when static linked is requested.
- From: Nick Clifton <nickc at redhat dot com>
- To: Cupertino Miranda <Cupertino dot Miranda at synopsys dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Claudiu dot Zissulescu at synopsys dot com" <Claudiu dot Zissulescu at synopsys dot com>, "Francois dot Bedard at synopsys dot com" <Francois dot Bedard at synopsys dot com>
- Date: Wed, 7 Jun 2017 13:23:09 +0100
- Subject: Re: [PATCH 1/9] [ARC] Avoid creating dynamic relocs when static linked is requested.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8539533459A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8539533459A
- References: <20170523154056.19234-1-cmiranda@synopsys.com> <20170523154056.19234-2-cmiranda@synopsys.com> <72c6dbb8-e3bc-d72d-abe2-65d00f7041aa@redhat.com> <EB86EB452ADE4B44B294F7149B8A2777026D21B9@DE02WEMBXB.internal.synopsys.com>
Hi Cupertino,
> If one invokes ADD_RELA when no dynamic sections get created, it would
> segmentation fault.
> However, invocations to this macro are being done eagerly and that is
> the reason for the simple condition fix.
>
> Honestly, thinking about it now I do not find a use case where it would
> be helpful to return an error message, but I can be wrong. :-(
> Do you have use case in mind?
None - I was just checking. Plus I like to be paranoid when programming
and it seemed to me that this might be a case where an error message would
have been helpful. But I understand your argument that the reloc generation
is done eagerly, so I have no more objections to the patch.
Approved - please apply.
Cheers
Nick