This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PR 21384, --dynamic-list regression with f02cb058
On Tue, May 2, 2017 at 3:28 PM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, May 02, 2017 at 01:57:49PM -0700, H.J. Lu wrote:
>> I checked in a test for this.
>
> Thanks. Incidentally, on my x86_64-linux box I've been seeing
>
> Executing on host: sh -c {gcc -B/home/alan/build/gas/all/ld/tmpdir/ld/ -L/usr/local/x86_64-linux/lib64 -L/usr/local/lib64 -L/lib64 -L/usr/lib64 -L/usr/local/x86_64-linux/lib -L/usr/local/lib -L/lib -L/usr/lib -o tmpdir/tls-1en -L/home/alan/src/binutils-gdb/ld/testsuite/ld-x86-64 -Wl,-z,now tmpdir/tls-main1.o tmpdir/libtls-1a.so tmpdir/libtls-1bn.so -Wl,-R,tmpdir tmpdir/dummy.o 2>&1} /dev/null ld.tmp (timeout = 300)
> spawn [open ...]
> tmpdir/libtls-1bn.so: undefined reference to `gd'
> collect2: error: ld returned 1 exit status
> tmpdir/libtls-1bn.so: undefined reference to `gd'
> collect2: error: ld returned 1 exit status
> FAIL: TLS without PLT (3)
>
> gcc (Ubuntu 4.9.4-2ubuntu1~16.04) 4.9.4
>
I checked in this patch. Please give it a try.
Thanks.
--
H.J.
From 3d8505928a06e00b05bb162c1ad0dd612c1c16af Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 2 May 2017 16:00:49 -0700
Subject: [PATCH] x86: Add -Wl,--no-as-needed to some TLS tests
* testsuite/ld-i386/tls.exp: Add -Wl,--no-as-needed to
"TLS without PLT (1)" and "TLS without PLT (3)".
* testsuite/ld-x86-64/tls.exp: Add -Wl,--no-as-needed to
to "TLS without PLT (3)".
---
ld/ChangeLog | 7 +++++++
ld/testsuite/ld-i386/tls.exp | 4 ++--
ld/testsuite/ld-x86-64/tls.exp | 2 +-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 4fc4e1d..ff52608 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,12 @@
2017-05-02 H.J. Lu <hongjiu.lu@intel.com>
+ * testsuite/ld-i386/tls.exp: Add -Wl,--no-as-needed to
+ "TLS without PLT (1)" and "TLS without PLT (3)".
+ * testsuite/ld-x86-64/tls.exp: Add -Wl,--no-as-needed to
+ to "TLS without PLT (3)".
+
+2017-05-02 H.J. Lu <hongjiu.lu@intel.com>
+
PR ld/21384
* testsuite/ld-elf/pr21384.d: New file.
* testsuite/ld-elf/pr21384.dl: Likewise.
diff --git a/ld/testsuite/ld-i386/tls.exp b/ld/testsuite/ld-i386/tls.exp
index 7a99e46..5fd42bc 100644
--- a/ld/testsuite/ld-i386/tls.exp
+++ b/ld/testsuite/ld-i386/tls.exp
@@ -141,7 +141,7 @@ run_ld_link_exec_tests [list \
] \
[list \
"TLS without PLT (1)" \
- "tmpdir/tls-main1.o \
+ "-Wl,--no-as-needed tmpdir/tls-main1.o \
tmpdir/libtls-1a.so tmpdir/libtls-1b.so -Wl,-R,tmpdir" \
"" \
{ dummy.s } \
@@ -159,7 +159,7 @@ run_ld_link_exec_tests [list \
] \
[list \
"TLS without PLT (3)" \
- "-Wl,-z,now tmpdir/tls-main1.o \
+ "-Wl,--no-as-needed -Wl,-z,now tmpdir/tls-main1.o \
tmpdir/libtls-1a.so tmpdir/libtls-1bn.so -Wl,-R,tmpdir" \
"" \
{ dummy.s } \
diff --git a/ld/testsuite/ld-x86-64/tls.exp b/ld/testsuite/ld-x86-64/tls.exp
index 5282146..4263d95 100644
--- a/ld/testsuite/ld-x86-64/tls.exp
+++ b/ld/testsuite/ld-x86-64/tls.exp
@@ -159,7 +159,7 @@ run_ld_link_exec_tests [list \
] \
[list \
"TLS without PLT (3)" \
- "-Wl,-z,now tmpdir/tls-main1.o \
+ "-Wl,--no-as-needed -Wl,-z,now tmpdir/tls-main1.o \
tmpdir/libtls-1a.so tmpdir/libtls-1bn.so -Wl,-R,tmpdir" \
"" \
{ dummy.s } \
--
2.9.3