This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gas: xtensa: fix incorrect code generated with auto litpools
- From: Nick Clifton <nickc at redhat dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, binutils at sourceware dot org
- Cc: Sterling Augustine <augustine dot sterling at gmail dot com>, David Weatherford <weath at cadence dot com>, Marc Gauthier <marc at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Mon, 10 Apr 2017 13:15:15 +0100
- Subject: Re: [PATCH] gas: xtensa: fix incorrect code generated with auto litpools
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 55FD7635E2
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 55FD7635E2
- References: <1491427212-18970-1-git-send-email-jcmvbkbc@gmail.com>
Hi Max,
> gas/
> 2017-03-31 Max Filippov <jcmvbkbc@gmail.com>
>
> * config/tc-xtensa.c (xtensa_maybe_create_literal_pool_frag):
> Initialize lps->frag_count with auto_litpool_limit.
> (xg_promote_candidate_litpool): New function.
> (xtensa_move_literals): Extract candidate litpool promotion code
> into separate function. Call it for all possible found
> candidates.
> (xtensa_switch_to_literal_fragment): Drop 'recursive' flag and
> call to xtensa_mark_literal_pool_location that it guards.
> Replace it with call to xtensa_maybe_create_literal_pool_frag.
> Initialize pool_location with created literal pool candidate.
> * testsuite/gas/xtensa/all.exp: Add new tests.
> * testsuite/gas/xtensa/auto-litpools-first1.d: New test results.
> * testsuite/gas/xtensa/auto-litpools-first1.s: New test.
> * testsuite/gas/xtensa/auto-litpools-first2.d: New test results.
> * testsuite/gas/xtensa/auto-litpools-first2.s: New test.
> * testsuite/gas/xtensa/auto-litpools.d: Fix offsets changed due
> to additional jump instruction.
Approved and applied.
Cheers
Nick