This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [WebAssembly] Disassembler support
- From: Nick Clifton <nickc at redhat dot com>
- To: Pip Cet <pipcet at gmail dot com>, binutils at sourceware dot org
- Date: Thu, 6 Apr 2017 17:22:42 +0100
- Subject: Re: [PATCH] [WebAssembly] Disassembler support
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1C6A84E4C5
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C6A84E4C5
- References: <CAOqdjBcc-R_Ba1yQoMddgijbFickSmWEn4zwYTokVrbYfD1Vig@mail.gmail.com>
Hi Pip,
> opcodes/:
> 2017-03-31 Pip Cet <pipcet@gmail.com>
>
> * Makefile.am: Add wasm32-dis.c.
> * configure.ac: Add wasm32-dis.c to wasm32 target.
> * disassemble.c: Add wasm32 disassembler code.
> * wasm32-dis.c: New file.
> * Makefile.in: Regenerate.
> * configure: Regenerate.
> * po/POTFILES.in: Regenerate.
>
> gas/:
> 2017-03-31 Pip Cet <pipcet@gmail.com>
>
> * testsuite/gas/wasm32/allinsn.d: Adjust test for disassembler
> changes.
> * testsuite/gas/wasm32/disass.d: New test.
> * testsuite/gas/wasm32/disass.s: New test.
> * testsuite/gas/wasm32/disass-2.d: New test.
> * testsuite/gas/wasm32/disass-2.s: New test.
> * testsuite/gas/wasm32/reloc.d: Adjust test for changed reloc names.
> * testsuite/gas/wasm32/reloc.s: Update test for changed assembler
> syntax.
> * testsuite/gas/wasm32/wasm32.exp: Run new tests. Expect allinsn
> test to succeed.
>
> include/:
> 2017-03-31 Pip Cet <pipcet@gmail.com>
>
> * dis-asm.h: Add prototypes for wasm32 disassembler.
Approved and applied.
Note - there was one problem:
> +static void
> +parse_wasm32_disassembler_options (struct disassemble_info *info,
> + char *opts)
> +{
The second parameter to this function is a const char * not a char *.
I fixed this as part of the check-in.
Cheers
Nick