This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/21233: Avoid sweeping forced-undefined symbols in section GC
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: macro at imgtec dot com
- Cc: amodra at gmail dot com, nickc at redhat dot com, binutils at sourceware dot org
- Date: Wed, 5 Apr 2017 03:13:43 +0200
- Subject: Re: [PATCH] PR ld/21233: Avoid sweeping forced-undefined symbols in section GC
- Authentication-results: sourceware.org; auth=none
> Date: Mon, 27 Mar 2017 12:39:07 +0100
> From: "Maciej W. Rozycki" <macro@imgtec.com>
> Which brings me a question to our general maintainers: which of the
> following 3 options shall I pick for the purpose of this test case:
> 2. File a PR referring to commit d968975277ba and its discussion and KFAIL
> the affected test cases for the problematic targets.
(or rather xfail; I don't know if there's a way to kfail with
run_ld_link_tests and I don't think we use that in binutils.)
I'm not a general maintainer, but FWIW my preference would have
been this, to xfail the failing parts and also add affected
maintainers on the ticket.
Thus this commit for "my" domain. The first part passed, so I
had to split up the list. I can then deal with the actual bug
at my discretion without being nagged by any autotesters that
make use of a regression-free status to trig on any fail.
Incidentally, arm-unknown-eabi also fails.
To those interested: the run_ld_link_tests source shows how to
add xfails for a target or use this as an example. (Not my
preferred test-driver function, I prefer to iterate on
run_dump_test *.d files; with a driver in place sometimes I only
have to add that one file with a descriptive comment inside.)
As a sanity check, I made sure mips-linux still passed all
tests.
diff --git a/ld/ChangeLog b/ld/ChangeLog
index d8b9a22..3cf9141 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2017-04-05 Hans-Peter Nilsson <hp@axis.com>
+
+ PR ld/21233
+ * testsuite/ld-elf/shared.exp: Xfail all PR21233 tests but the
+ first test for cris*-*-*.
+
2017-04-04 Maciej W. Rozycki <macro@imgtec.com>
PR ld/21233
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index be30ec0..291f9e1 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -130,7 +130,8 @@ if { [check_gc_sections_available] } {
"$LFLAGS -shared -T pr21233.ld" "" "$AFLAGS_PIC" \
{pr21233-l.s} \
{{readelf --dyn-syms pr21233-l.sd}} \
- "libpr21233.so"] \
+ "libpr21233.so"]]
+ run_ld_link_tests [list \
[list \
"PR ld/21233 dynamic symbols with section GC (--undefined)" \
"$LFLAGS --gc-sections -e foo --undefined=bar -T pr21233.ld" \
@@ -152,7 +153,7 @@ if { [check_gc_sections_available] } {
"tmpdir/libpr21233.so" "" \
{pr21233.s} \
{{readelf --dyn-syms pr21233.sd}} \
- "pr21233-3"]]
+ "pr21233-3"]] "cris*-*-*"
}
# Check to see if the C compiler works
brgds, H-P