This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] Implementing ARC NPS-400 Accelerator instructions cp16/cp32
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Rinat Zelig <rinat at mellanox dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Cupertino dot Miranda at synopsys dot com" <Cupertino dot Miranda at synopsys dot com>, "Noam Camus" <noamca at mellanox dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Mon, 20 Feb 2017 11:40:49 +0000
- Subject: RE: [PATCH] Implementing ARC NPS-400 Accelerator instructions cp16/cp32
- Authentication-results: sourceware.org; auth=none
- References: <1487484108-13175-1-git-send-email-rinat@mellanox.com> <DB6PR0501MB261504BA16ED5A3913826118C55F0@DB6PR0501MB2615.eurprd05.prod.outlook.com>
Hi,
> diff --git a/gas/ChangeLog b/gas/ChangeLog
> index 27e5885..83d179b 100644
> --- a/gas/ChangeLog
> +++ b/gas/ChangeLog
> @@ -1,3 +1,8 @@
> +2016-10-10 Rinat Zelig <rinat@mellanox.com>
> +
> + * testsuite/gas/arc/nps400-11.s: New file.
> + * testsuite/gas/arc/nps400-11.d: New file.
> +
Changelog entries shouldn't be part of the patch. Tough you need to provide them in the email body.
> diff --git a/include/ChangeLog b/include/ChangeLog
> index 8bcb0cf..e870134 100644
> --- a/include/ChangeLog
> +++ b/include/ChangeLog
> @@ -1,3 +1,7 @@
> +2016-10-10 Rinat Zelig <rinat@mellanox.com>
> +
> + * opcode/arc.h (insn_class_t): Add DMA class.
> +
Likewise.
> diff --git a/include/opcode/arc.h b/include/opcode/arc.h
> index f263fff..3271f4c 100644
> --- a/include/opcode/arc.h
> +++ b/include/opcode/arc.h
> @@ -76,7 +76,8 @@ typedef enum
> PUSH,
> STORE,
> SUB,
> - XY
> + XY,
> + DMA
We tend to keep this list in alphabetical order. Please insert DMA at its position.
> } insn_class_t;
Additional question: Did u tested your newly introduced tests also for little endian?
Otherwise it looks good,
Claudiu