This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ld, testsuite] XFAIL "pr20995-2", "Build pr20995-2.so" on arm*-*-eabi*

Hi Jiong,

> OK for master?

Almost...

+    # xfail on arm*-*-eabi*.  The list can be enlarged to those targets that
+    # don't support GNU_RELRO.
+    setup_xfail "arm*-*-eabi*"
     run_ld_link_tests {
 	{"Build pr20995-2.so"
 	    "-shared -z relro" "" ""
@@ -154,7 +157,7 @@ if { [check_shared_lib_support] } then {
 	    "pr20995" \
 	    "" "tmpdir/pr20995.so" "$AFLAGS_NONPIC" \
 	    {pr20995a.s} {{readelf {-S --wide} pr20995.r}} "pr20995"]]
-    setup_xfail "alpha-*-*" "bfin-*-*" "ia64-*-*" "xtensa-*-*"
+    setup_xfail "alpha-*-*" "bfin-*-*" "ia64-*-*" "xtensa-*-*" "arm*-*-eabi*"
     run_ld_link_tests [list \
 	[list \
 	    "pr20995-2" \

I think that you ought to extend the comment in the first thunk,
and add a comment in the second thunk, pointing readers at this
thread.  That way, future readers of this test can find out more
about why the xfails are there.

Approved with this change.

Cheers
  Nick
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]