This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/8] Return -1 on memory error in print_insn_msp430

From: Alan Modra <amodra at gmail dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org
Date: Thu, 12 Jan 2017 08:24:46 +1030
Subject: Re: [PATCH 4/8] Return -1 on memory error in print_insn_msp430
Authentication-results: sourceware.org; auth=none
References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-5-git-send-email-yao.qi@linaro.org>

On Tue, Jan 10, 2017 at 12:26:14PM +0000, Yao Qi wrote:
> 	* msp430-dis.c (msp430_singleoperand): Return -1 if
> 	msp430dis_opcode_signed returns false.
> 	(msp430_doubleoperand): Likewise.
> 	(msp430_branchinstr): Return -1 if
> 	msp430dis_opcode_unsigned returns false.
> 	(msp430x_calla_instr): Likewise.
> 	(print_insn_msp430): Likewise.

You missed nine msp430dis_opcode_signed calls.  OK with those done too.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH 4/8] Return -1 on memory error in print_insn_msp430
  - From: Yao Qi

References:
- [PATCH 0/8] Handle memory error on disassemble
  - From: Yao Qi
- [PATCH 4/8] Return -1 on memory error in print_insn_msp430
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]