This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/5] RISC-V/GAS: Improve handling of invalid relocs


Hi Palmer, Hi Andrew,

> 2016-12-21  Andrew Waterman <andrew@sifive.com>
> 
> 	* config/tc-riscv.c (md_apply_fix): Report TLS relocations against
> 	constants.  Report disallowed symbol subtractions.

Approved (for mainline) - please apply.

Cheers
  Nick

> +	as_bad_where (fixP->fx_file, fixP->fx_line,
> +		      _("TLS relocation against a constant"));

FYI - I think that it might be possible to trigger this error message when
something other than a constant is involved, eg an expression that is too
complex, or a register name is used instead of a symbol name.  In such cases
the error message might be considered a little confusing.  This is not a
big issue now, but more of a heads-up in case you get complaints from users.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]