This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [1/9][RFC][DWARF] Reserve three DW_OP numbers in vendor extension space
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: GDB <gdb-patches at sourceware dot org>, Binutils <binutils at sourceware dot org>, "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>, Nick Clifton <nickc at redhat dot com>
- Date: Tue, 3 Jan 2017 10:57:08 +0000
- Subject: Re: [1/9][RFC][DWARF] Reserve three DW_OP numbers in vendor extension space
- Authentication-results: sourceware.org; auth=none
- References: <c9da17a6-c3de-4466-c023-4e4ddbe38efb@foss.arm.com> <72418e98-a400-c503-e8ce-c3fbe1ecc4a7@foss.arm.com> <20161111193859.GJ3541@tucnak.redhat.com> <e69bcade-9596-7679-ebfe-d0c56e24f8b5@foss.arm.com> <20161115161817.GL3541@tucnak.redhat.com> <5896be40-51de-55f7-f4a1-4c5af7ff9aec@foss.arm.com> <ceb9dfac-9f94-0d78-7f3f-8f9e0a2abb66@arm.com> <bd3dae26-48c9-9f37-a1c8-001982cb6c78@foss.arm.com> <1479304496.14569.256.camel@redhat.com> <20161116140218.GU3541@tucnak.redhat.com> <07b84003-4e73-8a7f-f949-4c3500e4ffc4@foss.arm.com> <CAJimCsEnnDKC9vGE5XZWqzjmsF4C2Z7FOfxcF8Y3L2in=MMk_w@mail.gmail.com> <42e05bed-4819-3acb-1e3c-8982910e875f@foss.arm.com>
On Tue, Jan 3, 2017 at 10:09 AM, Jiong Wang <jiong.wang@foss.arm.com> wrote:
> On 28/12/16 19:54, Cary Coutant wrote:
>>>
>>> OK on this proposal and to install this patch to gcc trunk?
>>>
>>> Hi GDB, Binutils maintainer:
>>>
>>> OK on this proposal and install this patch to binutils-gdb master?
>>>
>>> include/
>>> 2016-11-29 Richard Earnshaw <rearnsha@arm.com>
>>> Jiong Wang <jiong.wang@arm.com>
>>>
>>> * dwarf2.def (DW_OP_AARCH64_operation): Reserve the number 0xea.
>>
>> This is OK, but:
>>
>> +/* AARCH64 extensions.
>> + DW_OP_AARCH64_operation takes one mandatory unsigned LEB128 operand.
>> + Bits[6:0] of this operand is the action code, all others bits are
>> initialized
>> + to 0 except explicitly documented for one action. Please refer
>> AArch64 DWARF
>> + ABI documentation for details. */
>>
>> Is it possible to include a stable URL that points to the ABI document?
>>
>> -cary
>
>
> As this patch has got approve from GCC, is it OK to install into
> binutils-gdb master?
>
> My understanding is "include/dwarf2.def" is shared between GDB and
> Binutils.
"include/dwarf2.def" in binutils-gdb is a copy from gcc, as the comments in
the top explain "This file is part of GCC.". Since the patch was approved in
GCC, you need to commit the patch to GCC repository, and sync
"include/dwarf2.def" from GCC repo to binutils-gdb repo. The last sync
is done by Nick https://sourceware.org/ml/binutils/2015-09/msg00330.html
>
> This patch and the described AArch64 DWARF proposal has got GDB ack from
> https://sourceware.org/ml/gdb-patches/2016-11/msg01008.html which, from my
> understanding, is a conditional approval given there is follow up GDB
> patches on multiplexing DW_CFA_GNU_window_save.
>
> This patch still need Binutils approval.
>
The sync is regarded as an obvious change, so you can commit it in
binutils-gdb repo.
--
Yao (齐尧)