This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 18/19] ld: testsuite: Sanitize output from ld

On Mon, Dec 05, 2016 at 10:42:33PM +0200, Dimitar Dimitrov wrote:
> +++ b/ld/testsuite/lib/ld-lib.exp
> @@ -984,6 +984,7 @@ proc run_dump_test { name {extra_options {}} } {
>  	}
>  
>  	regsub "\n$" $comp_output "" comp_output
> +	regsub "^--" $comp_output "" comp_output
>  	if { $cmdret != 0 || $comp_output != "" || $check_ld(source) != "" } then {
>  	    set exitstat "succeeded"
>  	    if { $cmdret != 0 } { set exitstat "failed" }

I'm not sure about this one, but all your other testsuite changes look
good.  Perhaps
  send_log -- "$comp_output\n"
later would be better.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]