This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] MIPS16: Remove unused `>' operand code
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Fri, 9 Dec 2016 23:28:38 +0000
- Subject: [committed] MIPS16: Remove unused `>' operand code
- Authentication-results: sourceware.org; auth=none
This code has never been used throughout the repository history, and
likely not before either, as due to the assymetry of MIPS16 instruction
set encoding there are no 32-bit shift operations having their immediate
shift count placed in the position of the usual `rx' instruction field.
gas/
* config/tc-mips.c (mips16_macro_build) <'>'>: Remove case.
include/
* opcode/mips.h: Remove references to `>' operand code.
opcodes/
* mips16-opc.c (decode_mips16_operand) <'>'>: Remove cases.
---
binutils-mips16-opcode-format-gt.diff
Index: binutils/gas/config/tc-mips.c
===================================================================
--- binutils.orig/gas/config/tc-mips.c 2016-11-30 00:01:31.000000000 +0000
+++ binutils/gas/config/tc-mips.c 2016-11-30 00:03:45.554795275 +0000
@@ -8725,7 +8725,6 @@ mips16_macro_build (expressionS *ep, con
break;
case '<':
- case '>':
case '4':
case '5':
case 'H':
Index: binutils/include/opcode/mips.h
===================================================================
--- binutils.orig/include/opcode/mips.h 2016-11-30 00:01:31.000000000 +0000
+++ binutils/include/opcode/mips.h 2016-11-30 00:04:33.378351392 +0000
@@ -1809,7 +1809,6 @@ extern int bfd_mips_num_opcodes;
The remaining codes may be extended. Except as otherwise noted,
the full extended operand is a 16 bit signed value.
"<" 3 bit unsigned shift count * 0 (MIPS16OP_*_RZ) (full 5 bit unsigned)
- ">" 3 bit unsigned shift count * 0 (MIPS16OP_*_RX) (full 5 bit unsigned)
"[" 3 bit unsigned shift count * 0 (MIPS16OP_*_RZ) (full 6 bit unsigned)
"]" 3 bit unsigned shift count * 0 (MIPS16OP_*_RX) (full 6 bit unsigned)
"4" 4 bit signed immediate * 0 (MIPS16OP_*_IMM4) (full 15 bit signed)
@@ -1834,7 +1833,7 @@ extern int bfd_mips_num_opcodes;
Characters used so far, for quick reference when adding more:
" 456 8 0"
- "[]<>"
+ "[]<"
"ABCDE HI KLM P RS UVWXYZ"
"a e ijklm pq vwxyz"
*/
Index: binutils/opcodes/mips16-opc.c
===================================================================
--- binutils.orig/opcodes/mips16-opc.c 2016-11-30 00:01:31.000000000 +0000
+++ binutils/opcodes/mips16-opc.c 2016-11-30 00:08:06.149412156 +0000
@@ -76,7 +76,6 @@ decode_mips16_operand (char type, bfd_bo
switch (type)
{
case '<': UINT (5, 0);
- case '>': UINT (5, 0);
case '[': UINT (6, 0);
case ']': UINT (6, 0);
@@ -105,7 +104,6 @@ decode_mips16_operand (char type, bfd_bo
switch (type)
{
case '<': INT_ADJ (3, 2, 8, 0, FALSE);
- case '>': INT_ADJ (3, 8, 8, 0, FALSE);
case '[': INT_ADJ (3, 2, 8, 0, FALSE);
case ']': INT_ADJ (3, 8, 8, 0, FALSE);