This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] readelf: use hex prefix for program header alignment

On Fri, 9 Dec 2016, Alan Modra wrote:
> On Thu, Dec 08, 2016 at 12:09:21PM -0500, Hans-Peter Nilsson wrote:
> > On Thu, 8 Dec 2016, Étienne Buira wrote:
> > > ---
> > >  binutils/readelf.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > Missing updates to the test-suite.  I'm guessing that's going to
> > be a big patch.  Also missing a changelog and it'd be nice with
> > some background why you want to change this now.
> Like you, I'd normally be concerned about readelf changes, and I was
> until I saw no test failures and looked carefully at the patch.

Wonderful  ...except it means we're missing coverage for
the case below. 1/2 :)

> The output being changed is for readelf -l without --wide on 64-bit
> ELF files.  It seems we invariably run readelf -l with --wide on such
> files.  Thus no testsuite impact.
> I think the patch is good for consistency with other readelf -l
> output.

Certainly, I was just curious whether there was a specific
reason that the OP wanted this change now.

brgds, H-P

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]