This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH v2] readelf: use hex prefix for program header alignment
On Thu, Dec 08, 2016 at 12:09:21PM -0500, Hans-Peter Nilsson wrote:
> On Thu, 8 Dec 2016, Étienne Buira wrote:
> > ---
> > binutils/readelf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/binutils/readelf.c b/binutils/readelf.c
> > index c5a628f..69d8889 100644
> > --- a/binutils/readelf.c
> > +++ b/binutils/readelf.c
> > @@ -4900,7 +4900,7 @@ process_program_headers (FILE * file)
> > (segment->p_flags & PF_R ? 'R' : ' '),
> > (segment->p_flags & PF_W ? 'W' : ' '),
> > (segment->p_flags & PF_X ? 'E' : ' '));
> > - print_vma (segment->p_align, HEX);
> > + print_vma (segment->p_align, PREFIX_HEX);
> > }
> > putc ('\n', stdout);
> Missing updates to the test-suite. I'm guessing that's going to
> be a big patch. Also missing a changelog and it'd be nice with
> some background why you want to change this now.
Like you, I'd normally be concerned about readelf changes, and I was
until I saw no test failures and looked carefully at the patch.
The output being changed is for readelf -l without --wide on 64-bit
ELF files. It seems we invariably run readelf -l with --wide on such
files. Thus no testsuite impact.
I think the patch is good for consistency with other readelf -l
Australia Development Lab, IBM