This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] MIPS/include: opcode/mips.h: Correct INSN_CHIP_MASK
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Wed, 7 Dec 2016 12:39:13 +0000
- Subject: [committed] MIPS/include: opcode/mips.h: Correct INSN_CHIP_MASK
- Authentication-results: sourceware.org; auth=none
Complement commit e407c74b5b60 ("Support for MIPS R5900 (Sony Playstation
2)"), <https://sourceware.org/ml/binutils/2012-12/msg00240.html>, and
commit 2c62985659da ("MIPS: Add Octeon 3 support") and update the chip
mask accordingly.
include/
* opcode/mips.h (INSN_CHIP_MASK): Update according to bit use.
---
The chip mask is not (anymore) used anywhere, which is likely why this
update has been missed twice already, and which probably also means the
macro can be removed altogether. Right now we have a (historical) mess
with these bits, so let's keep the macro for the time being and wait for
a further overall clean-up which I'll try to make soon.
Maciej
binutils-opcodes-mips-chip-mask.diff
Index: binutils/include/opcode/mips.h
===================================================================
--- binutils.orig/include/opcode/mips.h 2016-11-29 03:07:07.749218459 +0000
+++ binutils/include/opcode/mips.h 2016-11-29 03:08:18.355775918 +0000
@@ -1194,7 +1194,7 @@ static const unsigned int mips_isa_table
#undef ISAF
/* Masks used for Chip specific instructions. */
-#define INSN_CHIP_MASK 0xc3ff0f20
+#define INSN_CHIP_MASK 0xc3ff4f60
/* Cavium Networks Octeon instructions. */
#define INSN_OCTEON 0x00000800