This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold commit] PR 20834: Fix problem causing internal error when -z max-page-size is used


When the -z max-page-size option is used to set the ABI page size
larger than the default text segment starting address, we end up
trying to page align the text segment and moving the file header to a
non-zero offset, later causing an internal error.

This patch fixes the problem by bumping the default starting address
to the page size in that situation.

An alternate approach would have been to keep the default starting
address and separating the file header from the first load segment,
but IMO it's more useful to simply use a larger text segment starting
address.

-cary


2016-12-01  Cary Coutant  <ccoutant@gmail.com>

gold/
        PR gold/20834
        * target.h (Target::default_text_segment_address): Bump default
        start address up to ABI page size.

Attachment: pr20834.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]