This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCHv2] [Bug 20868] ld: aarch64: fix GD->IE relaxation in ilp32 mode
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: <binutils at sourceware dot org>, Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>, Andrew Pinski <pinskia at gmail dot com>
- Date: Wed, 30 Nov 2016 10:17:14 +0530
- Subject: Re: [PATCHv2] [Bug 20868] ld: aarch64: fix GD->IE relaxation in ilp32 mode
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1480355150-16177-1-git-send-email-ynorov@caviumnetworks.com> <fc76638d-1aee-ec35-0f37-f4ccdbc3198c@foss.arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Nov 29, 2016 at 04:45:12PM +0000, Jiong Wang wrote:
> On 28/11/16 17:45, Yury Norov wrote:
> >LD detects the access to TLS that it can optimize, but does it wrong
> >in ilp32 mode - actual address differs from expected.
> >
> >It's because ld it calculates the address with "ldr x0, [x0, #:gottprel_lo12:var]"
> >which is correct for lp64, but for ilp32 it should be "ldr w0, [x0, #:gottprel_lo12:var]".
> >This patch fixes it by checking arch info. Also it replaces "add x0, x1, x0" with
> >"add w0, w1, w0". This instruction doesn't make troubles now, but in ilp32 mode
> >32-bit registers should be used in this case.
> >
> >Test that reproduses the bug is here:
> >https://sourceware.org/bugzilla/attachment.cgi?id=9669
> >
> >v2: add test to the testsuite.
> >
> > * bfd/elfnn-aarch64.c: Fix gd-ie relocation in ilp32 mode
> > * ld/testsuite/ld-aarch64/aarch64-elf.exp: Add new test
> > * ld/testsuite/ld-aarch64/relocs-ilp32.ld: New file
> > * ld/testsuite/ld-aarch64/tls-relax-gd-ie-ilp32.d: Likewise.
>
> Looks good to me though I can't approve, just don't forget add PR
> target/20868 in your changelog.
Great. It's important for ILP32 as it fixes 5 extra failures of ~23
in glibc testsuite. Who can take it? I'd ping him personally.
Is my understanding correct that I have your ack?
Yury