This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][gold] Implement --build-id=uuid on MinGW/MSYS2.


> gold/ChangeLog
>
>         * layout.cc: Changes for MinGW32:
>         Include windows.h and rpcdce.h.
>         (Layout::create_build_id): Use UuidCreate() to generate uuid.

+  UuidCreateFn uuid_create =
+      (UuidCreateFn)GetProcAddress(rpc_library, "UuidCreate");

Please use a C++ style case here. With that change, the patch looks good.

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]