This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [SPARC] gas: detect DCTI couples in sparc


    
    > Tested in sparc-linux-gnu and sparc64-linux-gnu targets.
    > Ok for master?
    
    Approved - please apply, but...
    
    > +/* Non-zero if as should generate a warning if an unpredictable DCTI
    > +   (delayed control transfer instruction) couple is found.  */
    > +static int dcti_couples_detect;
    
    For clarity, I suggest that you change "as" to "the assembler" in the
    comment above.
    
    Also - is there any particular reason why you used the "int" type for
    this variable, when "bfd_boolean" might have been more appropriate ?
    
Committed.  Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]