This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold][powerpc] PR gold/20529 - relaxing loop never ends


Hi Cary, thanks for the review.

On Sat, Aug 27, 2016 at 9:23 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>>     2016-08-26  Han Shen  <shenhan@google.com>
>>
>>         PR gold/20529 - relaxing loop never ends.
>>
>>         * powerpc.cc (Stub_table::min_size_threshold_): New member to
>>         limit size.
>>         (Stub_table::set_min_size_threshold): New member function.
>>         (Stub_table::set_address_and_size): Add code to only allow size
>>         increase.
>>         (Target_powerpc::do_relax): Add code to record last size.
>
> This is OK. Thanks!
>
> Do you think it's serious enough to warrant a backport to 2.27?

I would say yes - an endless linking time is quite disruptive for any
develop cycle, although chances are slim that someone hit the bug (I
continuously monitor 100k of ppc targets, and this is the only one
gets affected.)

>
> -cary

Han Shen


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]