This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR gold/17704

The only problem I have now is one of attribution and copyright
assignment. I think the patch is substantial enough to require
copyright assignment from the original author, but I don't know who
"" is, and I can't find a copyright assignment on file
for either that email or Tresorit as a company.

NGG, can you identify yourself and let me know if you have a copyright
assignment filed?


On Thu, Aug 18, 2016 at 12:13 PM, Sriraman Tallam <> wrote:
> On Fri, Aug 12, 2016 at 8:33 AM, Cary Coutant <> wrote:
>>>> PR gold/17704
>>>> * (match_sections): Add new parameter section_addraligns.
>>>> Check section alignment and keep the section with the strictest
>>>> alignment.
>>>> (find_identical_sections): New local variable section_addraligns.
>>>> Store each section's alignment.
>>>> * testsuite/pr17704a_test.s: New file.
>>>> * testsuite/ (pr17704a_test): New test.
>>>> * testsuite/ Regenerate.
>> +  (void)section_addraligns;
>> This shouldn't be necessary, but if it really is, I'd prefer to use
>> ATTRIBUTE_UNUSED on the parameter.
>> Also, I get this when trying to apply the patch:
>> patch: **** malformed patch at line 146: diff --git
>> a/gold/testsuite/pr17704a_test.s b/gold/testsuite/pr17704a_test.s
>> I think you may have deleted too much when deleting the hunks for
>> testsuite/
> Sorry for the late response, fixed both problems. Patch attached.
> Thanks
> Sri
>> -cary

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]