This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PowerPC VLE changes
- From: Alan Modra <amodra at gmail dot com>
- To: Andrew Jenner <andrew at codesourcery dot com>
- Cc: binutils at sourceware dot org, Kwok Cheung Yeung <kcy at codesourcery dot com>
- Date: Wed, 27 Jul 2016 08:56:07 +0930
- Subject: Re: [PATCH] PowerPC VLE changes
- Authentication-results: sourceware.org; auth=none
- References: <2d04188d-78b3-bc63-a479-54f4035e51df@codesourcery.com>
On Tue, Jul 26, 2016 at 05:42:01PM +0100, Andrew Jenner wrote:
> bfd/ChangeLog:
>
> * elf32-ppc.c (is_branch_reloc): Recognise VLE branch relocations.
> (ppc_elf_howto_raw): Fix dst_mask of R_PPC_VLE_REL15.
> (ppc_elf_vle_split16): Clear field before inserting.
>
> opcodes/ChangeLog:
>
> * ppc-opc.c (vle_opcodes): Alias 'e_cmpwi' to 'e_cmpi' and
> 'e_cmplwi' to 'e_cmpli' instead.
> (OPVUPRT, OPVUPRT_MASK): Define.
> (powerpc_opcodes, vle_opcodes): Add entries.
You missed an include/ChangeLog entry, and that last line of
opcodes/ChangeLog is a little terse. Please expand it a little.
I'd say minimal requirement is:
(powerpc_opcodes): Add E200Z4 insns.
(vle_opcodes): Add context save/restore insns.
OK with that fixed.
--
Alan Modra
Australia Development Lab, IBM