This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][ld] Implement --build-id=uuid on MinGW/MSYS2.
- From: Alan Modra <amodra at gmail dot com>
- To: Igor Kudrin <ikudrin at accesssoftek dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Tue, 26 Jul 2016 22:30:41 +0930
- Subject: Re: [PATCH][ld] Implement --build-id=uuid on MinGW/MSYS2.
- Authentication-results: sourceware.org; auth=none
- References: <1469441771536.21344@accesssoftek.com>
On Mon, Jul 25, 2016 at 10:15:34AM +0000, Igor Kudrin wrote:
> +#else /* __MINGW32__ */
> + UUID uuid;
> + typedef RPC_STATUS (RPC_ENTRY *UuidCreateFn)(UUID *Uuid);
Formatting. Space before open parens of function args.
typedef RPC_STATUS (RPC_ENTRY *UuidCreateFn) (UUID *Uuid);
> + UuidCreateFn uuid_create = 0;
> +
> + HMODULE rpc_library = LoadLibrary("rpcrt4.dll");
Same.
HMODULE rpc_library = LoadLibrary ("rpcrt4.dll");
> + if (!rpc_library)
> + return FALSE;
> + uuid_create = (UuidCreateFn)GetProcAddress(rpc_library, "UuidCreate");
Again, and space after cast.
uuid_create = (UuidCreateFn) GetProcAddress (rpc_library, "UuidCreate");
and more below.
> + if (!uuid_create)
> + {
> + FreeLibrary(rpc_library);
> + return FALSE;
> + }
> +
> + if (uuid_create(&uuid) != RPC_S_OK)
> + {
> + FreeLibrary(rpc_library);
> + return FALSE;
> + }
> + FreeLibrary(rpc_library);
> + memcpy(id_bits, &uuid, size < sizeof(UUID) ? size : sizeof(UUID));
> +#endif /* __MINGW32__ */
Other than the formatting issues, I really don't have enough
familiarity with mingw to properly review the patch. So I'm passing
the buck to Nick.
--
Alan Modra
Australia Development Lab, IBM