This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PING PATCH] arc: Fix segfault when generating got entries for local symbols
Hi Cupertino,
> This patch is still needing approval by someone.
> Nick: Do you approve and apply, perhaps ? :-)
:)
>> bfd/ChangeLog:
>>
>> * arc-got.h (relocate_fix_got_relocs_for_got_info): Handle the case
>> where there's no elf_link_hash_entry while processing GOT_NORMAL got
>> entries.
>>
>> ld/ChangeLog:
>>
>> * testsuite/ld-arc/got-01.d: New file.
>> * testsuite/ld-arc/got-01.s: New file.
Approved and applied.
Note - you missed one small detail. The new test failed on a target
configured as arc-linux-uclibc. (Because there are only 7 entries in
section headers, not 9). I have taken the liberty of fixing this for
you, but in the future I would recommend testing patches on a variety
of different ARC target configurations.
Cheers
Nick