This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ld: Restore file offset after a plugin fails to claim a file


Hi Guys,

> /home/alan/src/binutils-gdb/ld/testplug.c: In function ‘record_read_length’:
> /home/alan/src/binutils-gdb/ld/testplug.c:173:26: warning: implicit declaration of function ‘isdigit’ [-Wimplicit-function-declaration]
>    while (*tmp != '\0' && isdigit (*tmp))

Wouldn't it be better to include "safe-ctype.h" and use ISDIGIT() instead ?

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]