This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: New binutils testsuite failures related to remove-relocations
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, binutils at sourceware dot org
- Date: Fri, 15 Jul 2016 11:11:47 +0100
- Subject: Re: New binutils testsuite failures related to remove-relocations
- Authentication-results: sourceware.org; auth=none
- References: <87vb07tg2h.fsf@redhat.com> <20160715093736.GF1256@bubble.grove.modra.org>
* Alan Modra <amodra@gmail.com> [2016-07-15 19:07:36 +0930]:
> On Fri, Jul 15, 2016 at 10:18:30AM +0100, Nick Clifton wrote:
> > Just changing the ".word" to ".int" in the remove-relocs-01.s file
> > fixes the assembly problems for me, but maybe you would prefer some
> > other solution.
>
> I had a fix in the works already. Committed.
Alan,
Thanks for fixing this so quickly.
Apologies for this regression... which leads me to a question:
Do you guys (or anyone) have a script(s) that they use for easily
testing binutils over many/all targets?
I have a pretty poor home grown script which currently is mostly for
building different targets. The testing side of the script is still
pretty raw which is why I missed these test failures[1]. I wonder
what you all use for testing over so many targets?
Again, sorry for the disruption, and thanks for the fix.
Andrew
[1] There's probably a proverb about a programmer blaming his scripts...
>
> Fixes failures on alpha, ia64, mcore, metag, moxie, and pj due to lack
> of 16-bit relocs.
>
> * testsuite/binutils-all/remove-relocs-01.s: Use .dc.a, not .word.
>
> diff --git a/binutils/testsuite/binutils-all/remove-relocs-01.s b/binutils/testsuite/binutils-all/remove-relocs-01.s
> index 642d54f..cfbd920 100644
> --- a/binutils/testsuite/binutils-all/remove-relocs-01.s
> +++ b/binutils/testsuite/binutils-all/remove-relocs-01.s
> @@ -1,19 +1,19 @@
> .section ".data.relocs.01", "aw"
> - .word rel_01_01
> - .word rel_01_02
> - .word rel_01_03
> + .dc.a rel_01_01
> + .dc.a rel_01_02
> + .dc.a rel_01_03
>
> .section ".data.relocs.02", "aw"
> - .word rel_02_01
> - .word rel_02_02
> - .word rel_02_03
> + .dc.a rel_02_01
> + .dc.a rel_02_02
> + .dc.a rel_02_03
>
> .section ".data.relocs.03", "aw"
> - .word rel_03_01
> - .word rel_03_02
> - .word rel_03_03
> + .dc.a rel_03_01
> + .dc.a rel_03_02
> + .dc.a rel_03_03
>
> .section ".data.01", "aw"
> - .word 0x1
> - .word 0x2
> - .word 0x3
> + .dc.a 0x1
> + .dc.a 0x2
> + .dc.a 0x3
>
> --
> Alan Modra
> Australia Development Lab, IBM