This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [binutils][PATCH] Avoid zero-length VLAs.


On Mon, Jun 13, 2016 at 9:03 AM, Brooks Moses <bmoses@google.com> wrote:
> On Mon, Jun 13, 2016 at 3:36 AM, Nick Clifton <nickc@redhat.com> wrote:
>>> Zero-length variable-length-arrays are not allowed in standard C99,
>>> and perhaps more importantly, they cause ASAN to complain.  (See,
>>> e.g., https://gcc.gnu.org/ml/gcc-patches/2013-09/msg00917.html.)
>>>
>>> With this patch, the libiberty tests, including demangler-fuzzer, are
>>> ASAN-clean.
>>
>> Thanks for reporting this problem.  Unfortunately you have reported it
>> to the wrong place!  The libiberty code is used by both the binutils and
>> gcc projects, but it is officially maintained by gcc.  So please could
>> you repost this bug report and patch to gcc-patches@gcc.gnu.org ?
>
> Will do.  Thanks for the quick reply!

And following up: This is now committed to GCC as r238233.

I'd offer to do a patch for integrating it to the binutils/gdb
repository, but I don't have commit access.  Looks like there are a
number of other differences in the cp-demangle.c file between the two
versions, as well.

Thanks,
- Brooks


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]