This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/20306: Skip version check for unreferenced and undefined symbol
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 28 Jun 2016 08:10:17 -0700
- Subject: Re: [PATCH] PR ld/20306: Skip version check for unreferenced and undefined symbol
- Authentication-results: sourceware.org; auth=none
- References: <20160628133718 dot GA29714 at intel dot com> <63a6805b-5c36-ddea-43d9-89db84d7b427 at redhat dot com>
On Tue, Jun 28, 2016 at 8:03 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
>> bfd/
>>
>> PR ld/20306
>> * elflink.c (elf_link_check_versioned_symbol): Return false
>> for unreferenced undefined symbol.
>>
>> ld/testsuite/
>>
>> * testsuite/ld-gc/gc.exp: Run pr20306 test.
>> * ld-gc/pr20306.c: New file.
>> * ld-gc/pr20306.d: Likewise.
>
> Approved - please apply.
>
This is what I checked in.
Thanks.
--
H.J.
From 418dff2da36789de74d11593fb091b760650cf46 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 28 Jun 2016 06:20:05 -0700
Subject: [PATCH] Skip version check for unreferenced and undefined symbol
No need to check version if symbol is unreferenced and undefined.
bfd/
PR ld/20306
* elflink.c (elf_link_check_versioned_symbol): Return false
for unreferenced undefined symbol.
ld/testsuite/
* testsuite/ld-gc/gc.exp: Run pr20306 test.
* ld-gc/pr20306.c: New file.
* ld-gc/pr20306.d: Likewise.
---
bfd/elflink.c | 3 ++-
ld/testsuite/ld-gc/gc.exp | 15 +++++++++++++++
ld/testsuite/ld-gc/pr20306.c | 2 ++
ld/testsuite/ld-gc/pr20306.d | 3 +++
4 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 ld/testsuite/ld-gc/pr20306.c
create mode 100644 ld/testsuite/ld-gc/pr20306.d
diff --git a/bfd/elflink.c b/bfd/elflink.c
index ad8493b..3e24940 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -9053,7 +9053,8 @@ elf_link_check_versioned_symbol (struct bfd_link_info *info,
case bfd_link_hash_undefined:
case bfd_link_hash_undefweak:
abfd = h->root.u.undef.abfd;
- if ((abfd->flags & DYNAMIC) == 0
+ if (abfd == NULL
+ || (abfd->flags & DYNAMIC) == 0
|| (elf_dyn_lib_class (abfd) & DYN_DT_NEEDED) == 0)
return FALSE;
break;
diff --git a/ld/testsuite/ld-gc/gc.exp b/ld/testsuite/ld-gc/gc.exp
index ffc619c..a6f3e13 100644
--- a/ld/testsuite/ld-gc/gc.exp
+++ b/ld/testsuite/ld-gc/gc.exp
@@ -146,3 +146,18 @@ if { [is_remote host] || [which $CC] != 0 } {
ld_compile "$CC $CFLAGS $cflags -O0" $srcdir/$subdir/pr19161-2.c tmpdir/pr19161-2.o
run_dump_test "pr19161"
}
+
+if { [is_elf_format] && [check_shared_lib_support] \
+ && ([is_remote host] || [which $CC] != 0) } {
+ run_cc_link_tests [list \
+ [list \
+ "Build libpr20306.so" \
+ "-shared" \
+ "-fPIC" \
+ {pr20306.c} \
+ {} \
+ "libpr20306.so" \
+ ] \
+ ]
+ run_dump_test "pr20306"
+}
diff --git a/ld/testsuite/ld-gc/pr20306.c b/ld/testsuite/ld-gc/pr20306.c
new file mode 100644
index 0000000..0968c73
--- /dev/null
+++ b/ld/testsuite/ld-gc/pr20306.c
@@ -0,0 +1,2 @@
+extern void foo();
+void bar() {foo();}
diff --git a/ld/testsuite/ld-gc/pr20306.d b/ld/testsuite/ld-gc/pr20306.d
new file mode 100644
index 0000000..07cc8e8
--- /dev/null
+++ b/ld/testsuite/ld-gc/pr20306.d
@@ -0,0 +1,3 @@
+#source: dummy.s
+#ld: -u foo --gc-sections tmpdir/libpr20306.so
+#error: .* generated: undefined reference to `foo'
--
2.7.4